From 4e35d562630802075607705225069557883cbf43 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Sat, 19 Sep 2020 10:44:50 -0400 Subject: [PATCH] fontchooser: Remove signal handlers in dispose Avoid ordering issues in dispose by disconnecting the rows_changed_cb handler first thing. --- gtk/gtkfontchooserwidget.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gtk/gtkfontchooserwidget.c b/gtk/gtkfontchooserwidget.c index ede2ce8bf4..0f380f34b9 100644 --- a/gtk/gtkfontchooserwidget.c +++ b/gtk/gtkfontchooserwidget.c @@ -856,6 +856,9 @@ gtk_font_chooser_widget_dispose (GObject *object) { GtkFontChooserWidget *self = GTK_FONT_CHOOSER_WIDGET (object); + g_signal_handlers_disconnect_by_func (self->selection, rows_changed_cb, self); + g_signal_handlers_disconnect_by_func (self->filter_model, rows_changed_cb, self); + self->filter_func = NULL; g_clear_pointer (&self->filter_data, self->filter_data_destroy); -- 2.30.2